docs: add structlog config #1031
Conversation
github-actions
bot
added
the
PR type: documentation 📚
Coverage report
This PR does not seem to contain any modification to coverable code. |
There was a problem hiding this comment.
Thanks for your contribution.
So you were mentioning in the issue that it wasn't working as intended ? Were you able to fix that ?
I wonder if we should, somehow, test that. Maybe install this in a procrastinate_demo project ? Do you have an opinion ? (I'm not saying you have to do this on the PR (but you may), just asking. Your PR may should get merged at some point, even without that)
docs/howto/production/logging.md
Outdated
|
|
||
| A minimal configuration would look like: | ||
|
|
||
| ```py |
There was a problem hiding this comment.
(I think we're using python elsewhere, rather than py)
Co-authored-by: Joachim Jablon <[email protected]>
|
Hm, I've tried your code and it hasn't worked on the demo so far. I'll try to share a complete traceback later, but has it been working for you ? |
Yes, it has on a bigger project. Did you try the minimal config or the one from the structlog docs? |
|
I tried the one from your PR, and tried to put it as-is in the sync demo. |
|
(Hm, I'm sorry, I think this PR went a bit out of sight. We should try and put this back on the table at some point, though I can't make specific commitment. Just wanted to state that I'm sorry we didn't put enough work yet to match the effort you made crafting the PR. But it's not lost.) |
Closes #1030
Successful PR Checklist:
PR label(s):