Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to cache job status when checking abortion #1129

Closed
wants to merge 1 commit into from

Conversation

medihack
Copy link
Member

@medihack medihack commented Jul 28, 2024

Closes #1083

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

I am not fully convinced that setting a default cache time on the worker itself is a good idea - it's a bit too much intransparent magic for my taste. Users may have completely different ideas about how long such a cache period should be (depending on the duration of the task itself).

@medihack medihack requested a review from a team as a code owner July 28, 2024 16:01
@github-actions github-actions bot added the PR type: feature ⭐️ Contains new features label Jul 28, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate
  job_context.py
Project Total  

This report was generated by python-coverage-comment-action

@medihack
Copy link
Member Author

medihack commented Aug 1, 2024

I will add this feature later to 3.x.

@medihack medihack closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: feature ⭐️ Contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set a cache option when polling for an abortion request
1 participant