Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE TRIGGER procrastinate_jobs_notify_queue_job_inserted AFTER INSERT OR UPDATE #1183

Open
medihack opened this issue Sep 6, 2024 · 0 comments
Milestone

Comments

@medihack
Copy link
Member

medihack commented Sep 6, 2024

Unrelated to this PR, but... shouldn't this trigger AFTER INSERT OR UPDATE ?

Currently what happens is that after a job fails and is retried, the worker needs a new job to work on, so it will request one immediately and usually will receive the retry. But if a worker finishes a job while shutting down, and the job fails and is retried, then the trigger won't trigger (because it's an update and not an insert) and we'll need to wait for longer for other workers to pick up the job.

But then, unrelated to this PR. Marking it here to remember opening an issue.

Originally posted by @ewjoachim in #1172 (comment)

@medihack medihack added this to the Version 3.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant