Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting this into two repos #10

Open
aguschin opened this issue Sep 7, 2021 · 0 comments
Open

Consider splitting this into two repos #10

aguschin opened this issue Sep 7, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@aguschin
Copy link
Contributor

aguschin commented Sep 7, 2021

We can split this into two separate repos, connected via CI/CD:

  1. One with lstm-model package, training scripts, Dockerfile.pipeline and DVC
  2. Another with Flask application, Heroku, Dockerfile.app, docker-compose.yml

This may help with clarity and also be an example of connecting two repos. Of course, in this case we won't support the monorepo. This could create extra work of splitting CI/CD, so it may be better to decide on this before that work has been started. Beside that, we'll have to update all links in "practical materials" sections and all videos with repo discussion if we record some.

CI/CD then could like this:

  1. When model should be updated (code changes, new data, schedule), CI is run in the 1st repo.
  2. Upon completion, this CI updates references to the model in the 2nd repo.
  3. Created commit triggers CI/CD in the 2nd repo, which run testing and re-deploys the REST API service with the new model.
@aguschin aguschin added enhancement New feature or request question Further information is requested labels Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant