Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tutorial to the latest android version #8

Open
g7fernandes opened this issue Nov 27, 2024 · 7 comments · May be fixed by #9
Open

Update the tutorial to the latest android version #8

g7fernandes opened this issue Nov 27, 2024 · 7 comments · May be fixed by #9
Assignees

Comments

@g7fernandes
Copy link
Member

That's it. Details discussed internally at ProFUSION

MaironLucas added a commit that referenced this issue Nov 28, 2024
The project is a little obsolete due to use android 11 on the build. So is necessary to update it targing to use android 14

Closes #8
@khvMX
Copy link

khvMX commented Nov 29, 2024

Hi there! Thanks for the efforts. I have been through that (migration to Android 14) recently so if you face any issues, I may be able to help.
Also, please consider joining https://aosp-devs.org and its discord server, if you would like more people to contribute :)

MaironLucas added a commit that referenced this issue Nov 29, 2024
The project is a little obsolete due to use android 11 on the build. So is necessary to update it targing to use android 14

Closes #8
@MaironLucas
Copy link

MaironLucas commented Nov 29, 2024

Oh, hi @khvMX. Maybe you can help me. Were you able to migrate and compile the sdk-addon?
I'am facing some troubles running the make sdk_addon command here. Looks like the java_sdk_library is trying to find the modules helloworldservice.api.public.latest, helloworldservice-removed.api.public.latest, helloworldservice.api.system.latest and helloworldservice-removed.api.system.latest, but this modules aren't being generated (or I don't know how to link then in the Android.bp). Have you faced something like that?

@khvMX
Copy link

khvMX commented Nov 29, 2024

It should also spit out a command to generate missing api interfaces. I did not need any versioning, so I am ok with unsafe_ignore_missing_latest_api: true, in java_sdk_library target. Strangely enough it still made me generate a bunch of empty files in api/ directory.

@MaironLucas
Copy link

MaironLucas commented Nov 29, 2024

I didn't really see this flag in the documentation, it's exactly what I need, thanks. I'll follow here, if there's any problem I'll ping you again

MaironLucas added a commit that referenced this issue Nov 29, 2024
The project is a little obsolete due to use android 11 on the build. So is necessary to update it targing to use android 14

Closes #8
@MaironLucas
Copy link

@khvMX did you have an idea of how can I fix this error?

build/make/core/tasks/sdk-addon.mk:83: error: overriding commands for target `out/host/linux-x86/obj/SDK_ADDON/profusion_sdk_addon_intermediates/profusion_sdk_addon--img/', previously defined at build/make/core/tasks/sdk-addon.mk:83
18:35:47 ckati failed with: exit status 1

@khvMX
Copy link

khvMX commented Dec 2, 2024

@MaironLucas I didn't have "overriding" problems, I usually had missing files because I was not building an emulator.
My understanding is that profusion_sdk_addon--img is the emulator package which you can create an AVD with and add to Android Studio. So you may be overriding/duplicating some of its targets, possibly by including something twice via call inherit-product.

Btw., if you want to have e.g., profusion_sdk_addon-linux-img instead of profusion_sdk_addon--img, you can add this to your sdk_addon makefile:

INTERNAL_SDK_HOST_OS_NAME := $(HOST_OS)

I have spent most of the time in the build/make/core/tasks/sdk-addon.mk, often that was the only source of answers.

MaironLucas added a commit that referenced this issue Dec 2, 2024
The project is a little obsolete due to use android 11 on the build. So is necessary to update it targing to use android 14

Closes #8
@MaironLucas MaironLucas linked a pull request Dec 2, 2024 that will close this issue
@MaironLucas MaironLucas linked a pull request Dec 2, 2024 that will close this issue
@MaironLucas
Copy link

@khvMX I thinked that "call inherit-product" can be trying to create the img twice, but I can't find where this is happening. Honestly, this is my first time working with AOSP and SDK-Addon, so I don't understand exactly how the things work and connect yet.
I already tried to remove the $(call inherit-product, device/profusion/profusion_sdk_addon/profusion_sdk_addon.mk) line from aosp_x86_64.mk and the $(call inherit-product, device/profusion/common/profusion-packages.mk) line from mainline_system.mk. But this way compilation failed on the begining.
I created a draft for the branch I'm working on, can you take a quick look and see if you spot something that I am doing wrong?

MaironLucas added a commit that referenced this issue Dec 4, 2024
The project is a little obsolete due to use android 11 on the build. So is necessary to update it targing to use android 14

Part #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants