Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helm pre-delete hook to remove configurations before Akri chart c… #717

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Add Helm pre-delete hook to remove configurations before Akri chart c… #717

merged 4 commits into from
Nov 11, 2024

Conversation

kate-goldenring
Copy link
Contributor

@kate-goldenring kate-goldenring commented Nov 5, 2024 •
edited
Loading

ref #706

scb01
scb01 reviewed Nov 5, 2024
View reviewed changes
deployment/helm/templates/rbac.yaml Outdated Show resolved Hide resolved
deployment/helm/templates/pre-delete-job.yaml Show resolved Hide resolved
deployment/helm/templates/pre-delete-job.yaml Outdated Show resolved Hide resolved
deployment/helm/templates/rbac.yaml Outdated Show resolved Hide resolved
@kate-goldenring kate-goldenring force-pushed the helm-delete-configs-hook branch 2 times, most recently from 229988a to 5db17fb Compare November 6, 2024 03:37
@kate-goldenring
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Nov 8, 2024
diconico07
diconico07 reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@diconico07 diconico07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the possible race between helm and the agent that may happen here, LGTM.

deployment/helm/templates/pre-delete-job.yaml Outdated Show resolved Hide resolved
@kate-goldenring
Bump version
3700a60 
Signed-off-by: Kate Goldenring <[email protected]>
@kate-goldenring
Copy link
Contributor Author

version.sh runs cargo update which caused a dep of the onvif discovery handler to bump in a way the updated the ONVIF XML output should be expected by the test_create_onvif_discovery_message test. Pushed an update to the test to fix it

@kate-goldenring kate-goldenring merged commit edc2803 into project-akri:main Nov 11, 2024
31 checks passed
@kate-goldenring kate-goldenring deleted the helm-delete-configs-hook branch November 11, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scb01 scb01 scb01 left review comments

@diconico07 diconico07 diconico07 approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@johnsonshih johnsonshih Awaiting requested review from johnsonshih johnsonshih is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kate-goldenring @diconico07 @scb01