Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 22 compatibility #131

Open
bitmarkcc opened this issue Jan 10, 2024 · 0 comments
Open

Ubuntu 22 compatibility #131

bitmarkcc opened this issue Jan 10, 2024 · 0 comments

Comments

@bitmarkcc
Copy link

bitmarkcc commented Jan 10, 2024

Ubuntu 22 uses gcc-11 as default, and this causes compilation and runtime errors.

In a previous issue I mentioned to notify users that we don't support gcc-11, but now I have a possible solution:

First is to update blake: bitmarkcc@cb67862
The code for this comes from here: https://github.com/BLAKE2/BLAKE2/tree/20190724/ref

Next, we need to fix Lyra2REv2 because with the current code the gcc-11 compiler produces a runtime error (incorrect hash) for this algorithm and thus nodes can't sync. I dealt with this before with a sort of hack in my lm branch: bitmarkcc@cb67862 (see the changes to src/bmw.c). But I think a better solution is to use a different implementation of the BMW hash, at least for lyra2. x17 uses the 512 bit BMW hash and it works fine, so we can leave that as is. The implementation of BMW I found is here: https://github.com/floodyberry/supercop/tree/master/crypto_hash/bmw256/ref and it looks like a reputable repository. The patch that uses this for Bitmark is here: bitmarkcc@f6faae9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant