Have DataModel::Provider be an argument to Server Init parameters
#36558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
github-actions
bot
added
examples
platform
esp32
linux
controller
app
telink
tests
silabs
nxp
|
PR #36558: Size comparison from 5cd0c0d to 3718f06 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, psoc6, stm32, telink, tizen)
|
|
PR #36558: Size comparison from 5cd0c0d to 5f72e57 Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
…tedhomeip into provider_in_server_init
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
…tedhomeip into provider_in_server_init
|
PR #36558: Size comparison from 5cd0c0d to d9c01e9 Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36558: Size comparison from 5cd0c0d to 6724a26 Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Nov 20, 2024
|
PR #36558: Size comparison from c197bc2 to ba14e7e Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
tehampson
reviewed
Nov 20, 2024
tehampson
approved these changes
Nov 20, 2024
|
PR #36558: Size comparison from c197bc2 to de10790 Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 20, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…roject-chip#36558) * Set a provider in server init * Restyle * Fix some include dependencies * Add back missing include * Undo change for nrf * Add import for android * Undo qpg change * Update examples/all-clusters-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/light-switch-app/qpg/src/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/lock-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/lit-icd-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/controller/python/chip/server/ServerInit.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Help users update * Added comment * Restyled by prettier-markdown * Update examples/lock-app/qpg/src/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/platform/infineon/cyw30739/matter_config.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/platform/telink/common/src/AppTaskCommon.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/pump-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/platform/openiotsdk/app/openiotsdk_platform.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Fix includes * Removed an include * Update examples/pump-controller-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/shell/shell_common/cmd_server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/window-app/nrfconnect/main/AppTask.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove extra include * More comments updated * Remove unneeded dependency * Fix log * Update src/app/server/Server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove double init --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the app side for #36230
Added an
DataModel::Providerinit argument to server init params and make use of that in all main functions in our examples and code.