Set dataModelProvider as a required argument for Controller::FactoryInitParams
#36613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
github-actions
bot
added
the
documentation
|
PR #36613: Size comparison from 04e6a68 to f2b6852 Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36613: Size comparison from 04e6a68 to 082aadf Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
…n model. We now fully expect all applications to provide a data model provider
|
PR #36613: Size comparison from 04e6a68 to 782eb1b Increases above 0.2%:
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
…onnectedhomeip into chip_factory_init_data_model
|
PR #36613: Size comparison from 04e6a68 to 4bfa467 Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Nov 22, 2024
|
PR #36613: Size comparison from 04e6a68 to f809d68 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 22, 2024
tcarmelveilleux
approved these changes
Nov 22, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
…ryInitParams` (project-chip#36613) * Add dataModelProvider to Factor init parameters for the codegen data model provider * make setting the same data model on interaction model provider a noop * Fix compile * Fix links * Restyle * Restyled by prettier-markdown * Fix text * Fix some deps * Restyled by gn * Remove dependencies/auto-init of codegen data model in the interaction model. We now fully expect all applications to provide a data model provider * Fix include * Update src/app/InteractionModelEngine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Address some code review comments * Fix unit tests * Restyle * Add more comments about why we have very intentional ordering --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what #36558 did for server, this is the controller side.