[Android] Fix AndroidDeviceControllerWrapper::Shutdown() #36811
Merged
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yunhanw-google
force-pushed
the
feature/fix_android_shutdown
branch
from
6bd9cfa to
7728ea7
Compare
|
PR #36811: Size comparison from 7ceaf6f to 7728ea7 Full report (3 builds for cc32xx, stm32)
|
yunhanw-google
force-pushed
the
feature/fix_android_shutdown
branch
from
7728ea7 to
af57a17
Compare
|
PR #36811: Size comparison from 7ceaf6f to af57a17 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Dec 11, 2024
sharadb-amazon
approved these changes
Dec 12, 2024
Fix AndroidDeviceControllerWrapper::Shutdown() and make destructor call this shutdown, and further create mInitialized state to guarantee shutdown proceudre can be executed only once
yunhanw-google
force-pushed
the
feature/fix_android_shutdown
branch
from
af57a17 to
ba9e361
Compare
|
PR #36811: Size comparison from 74ff0fb to ba9e361 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AndroidDeviceControllerWrapper::Shutdown() and make destructor call this shutdown, and further create mInitialized state to guarantee shutdown procedure can be executed only once.
fixes: #33630