If compiling against libc++ without filesystem, don't reference fstream #37762
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37762: Size comparison from ff7398a to d3f3ecc Full report (5 builds for cc32xx, stm32, tizen)
|
stevew817
force-pushed
the
bugfix/armllvm
branch
from
d3f3ecc to
e963197
Compare
|
PR #37762: Size comparison from 64ae4d8 to e963197 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 25, 2025
andy31415
requested changes
Feb 25, 2025
SetupPayloadHelper uses filesystem calls, which may not be implemented when using a standard library which does't provide such functionality (such as libc++ on embedded targets). This change avoids compiling in the helper functions into the library on these targets by default, as the only in-tree consumer of these functions currently is the qrcodetool which is only built on host.
stevew817
force-pushed
the
bugfix/armllvm
branch
from
e963197 to
753d120
Compare
|
@andy31415 Does this look better to you? I didn't find a good property to |
|
PR #37762: Size comparison from 16c99f6 to 753d120 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 26, 2025
adigie
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetupPayloadHelper.cpp is compiled as part of the
setup_payloadstatic library, which is built for (almost?) all targets, even if those targets may not have an onboard filesystem. For GCC's libstdc++ this doesn't matter as it still provides a stub for std::ifstream, but LLVM's libc++ doesn't and throws a compiletime error because of this reference.The alternative to this patch is to move out SetupPayloadHelper.cpp from the
setup_payloadlibrary into theqrcodetoolexecutable, since that seems to be the only place the contents of SetupPayloadHelper are in use?Testing
Tested on EFR32 with GCC and ARM LLVM toolchains.