Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MA-21007 integrate libtrustymatter #37785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-sunxc
Copy link

the libtrustymatter third-party lib contains the Trusty IPC infrastructure and client application in the Non-secure side.

Change-Id: Id2cb5ccc0006d9f51cab06ed971174a94aa0111f

Reviewed-on: http://androidsource.nxp.com/project/21249
Reviewed-by: Elven Wang [email protected]
Reviewed-on: http://androidsource.nxp.com/project/23003

the libtrustymatter third-party lib contains the Trusty IPC
infrastructure and client application in the Non-secure side.

Change-Id: Id2cb5ccc0006d9f51cab06ed971174a94aa0111f
Signed-off-by: Ji Luo <[email protected]>
Reviewed-on: http://androidsource.nxp.com/project/21249
Reviewed-by: Elven Wang <[email protected]>
Reviewed-on: http://androidsource.nxp.com/project/23003
Copy link

Review changes with  SemanticDiff

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-sunxc please provide background details on what this is and intended usage. This PR seems to just add things to third-party (yet some compiles already fail ... that is odd).

What is the intended path to use for this library?
Why is it appropriate to have this on every platform?

@@ -354,3 +354,6 @@
url = https://github.com/paullouisageneau/libdatachannel.git
platforms = linux
recursive = true
[submodule "third_party/libtrustymatter/repo"]
path = third_party/libtrustymatter/repo
url = https://github.com/nxp-imx/libtrustymatter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be nxp-imx. Should the platforms be nxp then?

@andy31415
Copy link
Contributor

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces the libtrustymatter library. The changes are relatively simple, involving adding a submodule and a BUILD.gn file. I've provided some suggestions to improve the organization and clarity of the BUILD.gn file. Please review and address these comments.

Summary of Findings

  • BUILD.gn file organization: Consider grouping related source files together in the BUILD.gn file for better readability and maintainability.
  • Copyright header: The copyright header in BUILD.gn includes "Project CHIP Authors". Verify if this is the correct copyright holder for this project or if it needs to be adjusted.

Assessment

The pull request integrates the libtrustymatter library, which contains the Trusty IPC infrastructure and client application. The changes involve adding a submodule and a BUILD.gn file. Overall, the integration seems straightforward. I've provided some feedback regarding the BUILD.gn file to improve readability and maintainability. Please address these comments before merging, and ensure that others review and approve this code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants