feat: Added check for binaries to skip "installToolsCmd" #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are present Signed-off-by: Akash Singh <[email protected]>
SkySingh04
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 32.51% 33.96% +1.45%
==========================================
Files 17 18 +1
Lines 1621 1534 -87
==========================================
- Hits 527 521 -6
+ Misses 1062 980 -82
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
|
@Akash-Singh04 is there a specific image we can test the changes with? Also its failing lint fix (you can run golangci-lint run) and the PR title is failing semantics check due to Feat vs feat. |
| @@ -353,6 +372,7 @@ func (rm *rpmManager) probeRPMStatus(ctx context.Context, toolImage string) erro | |||
| return nil | |||
| } | |||
|
|
|||
|
|
|||
| toolsInstalled := toolingBase.Run(llb.Shlex(installToolsCmd), llb.WithProxy(utils.GetProxy())).Root() | ||
| toolsApplied := rm.config.ImageState.File(llb.Copy(toolsInstalled, "/usr/sbin/busybox", "/usr/sbin/busybox")) | ||
| toolList := []string{"dnf", "microdnf", "rpm", "yum"} | ||
| missingTools := make([]string, 0) |
There was a problem hiding this comment.
I think the tools we want to check are busybox cpio dnf-utils? and if they are not already present, we want to be able to install them with microdnf,yum etc rather than just tdnf
sozercan
changed the title
sozercan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated probeRPMStatus to check if binaries are present and only if not present to all installToolsCmd
Closes #652 #651