-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Unblock trivy dependency updates #750
ci: Unblock trivy dependency updates #750
Conversation
Signed-off-by: jpayne3506 <[email protected]>
Signed-off-by: jpayne3506 <[email protected]>
Signed-off-by: jpayne3506 <[email protected]>
Signed-off-by: jpayne3506 <[email protected]>
Also, I leveraged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 47.46% 47.46%
=======================================
Files 18 18
Lines 1677 1677
=======================================
Hits 796 796
Misses 826 826
Partials 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
yes! I think it would be good to document this |
Signed-off-by: jpayne3506 <[email protected]>
Updates
go.opentelemetry.io/otel/sdk/metric
fromv1.21.0
tov1.27.0
to unblock Trivy updates. This has been blocking all Trivy updates afterv0.51.4
as you could not build thepatch
package. Links below to relevant < workflow | PR >RCA of the issue is Trivy using
go.opentelemetry.io/otel/metric
but notgo.opentelemetry.io/otel/sdk/metric
. Causing a version mismatch with breaking results within the repo.Link for release notes:
Notes:
go.opentelemetry.io/otel/sdk/metric
is fromcopacetic/pkg/patch/patch.go
Line 161 in 10fd0c7
Closes #729