Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the testing of mitls for the everest nightly upgrade job #47

Open
msprotz opened this issue Jan 25, 2017 · 2 comments
Open

Enhance the testing of mitls for the everest nightly upgrade job #47

msprotz opened this issue Jan 25, 2017 · 2 comments
Assignees
Labels

Comments

@msprotz
Copy link
Member

msprotz commented Jan 25, 2017

  • The purpose of everest nightly upgrade is to pull the latest master of each project, check that everything "works together", then commit and push.
  • Right now, the definition of "works together" is: "build, then mitls.exe -v 1.2 www.google.com 443" works.

Task description.

  • First sub-task. "Works together" should include "verifies."
    • create a "verify" action for the everest script that launches the verification of mitls (the right invocation can be found under the mitls-ci target of the ci script)
    • make the ci script call everest verify in addition to build and test
  • Second sub-task. The call to mitls.exe is suboptimal. It should use -tlsapi, but then we get a not found error.
    • From Antoine:

      as for your 404 error on test it's because the request on -tlsapi is not for /
      you can change the payload in test/TestAPI.fst
      may be worth putting as a config option for mitls.exe

    • Then, figure out why the test ends up with ReadError: TCP close; if this is an actual error, the return code should be non-zero. If it's not, it shouldn't say error.
@msprotz
Copy link
Member Author

msprotz commented Feb 3, 2017

I did the first sub-task.

@msprotz msprotz added P2 and removed P1 labels Oct 4, 2017
@msprotz msprotz assigned fournet and unassigned sishtiaq Oct 4, 2017
@msprotz
Copy link
Member Author

msprotz commented Oct 4, 2017

@fournet can you at least comment on how we could improve the testing of mitls.exe? https://github.com/project-everest/everest/blob/master/everest#L833 this is what we run, which in turn is https://github.com/mitls/mitls-fstar/blob/master/src/tls/Extracted.mk#L120 -- maybe run more interop, post a report in the logs, something...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants