-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix umount cleanup with new metadata location
Since eaa7b43, Umount was not cleaning up backing devices correctly, but this was not caught in tests. Stacker's test suite had a test that noticed. It isn't clear that Umount as used in the `atomfs` cli tool was correct before eaa7b43 either, because the underlying atom mount points were put under the overmounted final mount point, and would thus not be shared by other molecule mounts. This also wasn't being tested though. This commit fixes Umount, and: - consolidates all unmounting logic - out of `cmd/umount` and into the package in `atomfs.Umount`. - adds a version of the test from Stacker that noticed this - that test belongs here instead of in stacker. Also fixed a couple seeming typos in that test that hid failures. - fixes the lock path used in Umount to match that used in Mount, which was out of sync since eaa7b43 - splits out the verity.go squashfs.Umount code to allow for getting backing devices of an atom without unmounting it, in order to only clean up the backing dev if it is no longer in use Signed-off-by: Michael McCracken <[email protected]>
- Loading branch information
1 parent
eaa7b43
commit 0e101bd
Showing
8 changed files
with
232 additions
and
107 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
base: | ||
from: | ||
type: oci | ||
url: /tmp/atomfs-test-oci:busybox | ||
run: touch /base | ||
a: | ||
from: | ||
type: built | ||
tag: base | ||
run: touch /a | ||
b: | ||
from: | ||
type: built | ||
tag: base | ||
run: touch /b | ||
c: | ||
from: | ||
type: built | ||
tag: base | ||
run: touch /c |
Oops, something went wrong.