Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite it entirely... again #168

Closed
altf4 opened this issue Jun 23, 2021 · 3 comments
Closed

Rewrite it entirely... again #168

altf4 opened this issue Jun 23, 2021 · 3 comments

Comments

@altf4
Copy link

altf4 commented Jun 23, 2021

The last one went so well!

@NikhilNarayana
Copy link
Member

:p

@vinceau
Copy link
Member

vinceau commented Aug 24, 2021

This but unironically.

We have an ongoing frustration where we're dependent on electron-webpack for our build management but the dependency is no longer maintained. electron-webpack has issues with newer versions of electron v8+ where the source maps are not generated correctly which makes development a pain.

If we have any hope of upgrading Electron we may need to ditch electron-webpack completely in favour of just managing our own build configurations. We don't necessarily have to do this from scratch since there are plenty of boilerplates out there. A trusted one is this one for example.

We might also want to take this opportunity to take advantage of preload.js for our bridge communication so we can hopefully disable node integration in the renderer thread.

@NikhilNarayana
Copy link
Member

See #222 for further details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants