Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add logging guidelines #1884

Merged
merged 1 commit into from
Oct 4, 2023
Merged

docs: add logging guidelines #1884

merged 1 commit into from
Oct 4, 2023

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Oct 4, 2023

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be an easy way to find this file. Maybe mention it in the contributing guide?
There are also other readmes in the same situation, "hidden" under different packages. Maybe we should have a way to advertise them

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1884 (8317732) into main (c640735) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
+ Coverage   92.01%   92.05%   +0.03%     
==========================================
  Files         152      152              
  Lines       26378    26378              
==========================================
+ Hits        24273    24281       +8     
+ Misses       1555     1548       -7     
+ Partials      550      549       -1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rchincha rchincha merged commit b196369 into project-zot:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants