-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reason to have "name" label? #48
Comments
We use this in build service to construct image name. Name of dist-git repo is different from |
@TomasTomecek how do then set the "name" label when doing Docker build? How is that different from tagging the image with that name? |
Here's the workflow:
This can be changed/updated of course. It's just what we use now. |
@TomasTomecek when you tagging the image, can you change the image name instead of adding the |
I think there is slight misunderstanding here: without So, we could get rid of the label, but we would have to find new way how to get final image name. Basically a mapping between |
What is the reason to have the
name
label if it matches with the image name? Both OS and Kubernetes havedisplay-name
label which provides more information in human-readable form about the image content. For example: https://github.com/openshift/sti-ruby/blob/master/2.2/Dockerfile#L13The text was updated successfully, but these errors were encountered: