Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use pytest-flake8 and pytest-black #549

Closed
wants to merge 1 commit into from

Conversation

winged
Copy link
Contributor

@winged winged commented Jul 3, 2019

Instead of calling flake8 / black explicitly, add them to pytest. This
should help with forgetting to call those tools before committing, as
it's only one commandline call now instead of three.

Instead of calling flake8 / black explicitly, add them to pytest.  This
should help with forgetting to call those tools before committing, as
it's only one commandline call now instead of three.
@sliverc
Copy link
Member

sliverc commented Jul 4, 2019

I see the benefit this could be bring, though not so sure about this change because of following reasons:

I think it's kind of developer taste which way to go so would it be an option to document usage of pytest-flake8 and pytest-black in CONTRIBUTING.md and a developer can then choose whether to use its own editor, pre-commit or pytest plugins. What do you think?

Otherwise if we want to integrate per default into Caluma it would be good to get the feedback of other regular committers.

@winged
Copy link
Contributor Author

winged commented Jul 9, 2019

Yeah makes sense

@winged winged closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants