This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
pkg/analysis/importalias: add tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
=========================================
+ Coverage 0 83.95% +83.95%
=========================================
Files 0 1 +1
Lines 0 81 +81
=========================================
+ Hits 0 68 +68
- Misses 0 8 +8
- Partials 0 5 +5
Continue to review full report at Codecov.
|
ldez
commented
Feb 27, 2021
| package a | ||
|
|
||
| import ( | ||
| // envoy_api_v2_auth "github.com/envoyproxy/go-control-plane/envoy/api/v2/auth" |
There was a problem hiding this comment.
The readme suggests that is a valid import but it doesn't work.
https://github.com/projectcontour/lint/blob/main/README.md#linters
Signed-off-by: Fernandez Ludovic <[email protected]>
ldez
commented
Feb 28, 2021
Comment on lines
+21
to
+22
| meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1" // want `alias "v1" uses words that are not in path "io/apimachinery/pkg/apis/meta/v1"` | ||
| meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1" // want `version "v1" not specified in alias "meta" for import path "k8s/io/apimachinery/pkg/apis/meta/v1"` |
There was a problem hiding this comment.
the suggestions can produce some duplicates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because tests are good 😸