Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test suite #244

Open
elbenfreund opened this issue Mar 6, 2020 · 0 comments
Open

Fix broken test suite #244

elbenfreund opened this issue Mar 6, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@elbenfreund
Copy link
Collaborator

After a long time of inactivity, the test suite is utterly broken due to outdated tooling.

Given that python2 is EOL now, any fixes can be limited to python3.

@elbenfreund elbenfreund added the Bug label Mar 6, 2020
@elbenfreund elbenfreund added this to the 0.14.0 milestone Mar 6, 2020
@elbenfreund elbenfreund self-assigned this Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
This is just a short term solution in order to get the whole test suite
running again as a solid baseline.

Ref.: #245, #244
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
This dealt addresses messages like this:
```
DeprecationWarning: <class
'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.force_flush
has been deprecat ed as of 2.8.0 and will be removed in 3.0.0. Please
set ``<class
'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.sqlalchemy_session_persistence
= 'flush'`` instead.
```

Ref.: #244
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
This dealt addresses messages like this:
```
DeprecationWarning: <class
'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.force_flush
has been deprecat ed as of 2.8.0 and will be removed in 3.0.0. Please
set ``<class
'tests.backends.sqlalchemy.factories.AlchemyFactFactory.Meta'>.sqlalchemy_session_persistence
= 'flush'`` instead.
```

Ref.: #244
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
elbenfreund added a commit that referenced this issue Mar 6, 2020
Due to recent work on legacy hamster, the old referenes (on master) do
not work anymore. As they were just optional references anyway, they got
removed.

Ref.: #244
elbenfreund added a commit that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant