Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement needed for documentation. #27

Open
raikusy opened this issue Feb 11, 2020 · 1 comment
Open

Improvement needed for documentation. #27

raikusy opened this issue Feb 11, 2020 · 1 comment

Comments

@raikusy
Copy link

raikusy commented Feb 11, 2020

Hello, I am using atomize in one of my soon to be released project. I loved the concept how atomize works.
But I feel the documentation needs more work. Also there aren't any release changelog in github.
It would be good to have a changelog so that I can keep track with version updates.
Also any plan of moving the examples to functional components and introducing more hooks?

Also I had some confusions, Can I use styled-components with atomize if I want to? Or is styled-components actually needed? Or I can achieve almost everything without it?
Also, you designed to pass every possible styles through props, is there any special reason about this? As many developers might not like the idea of passing props for every styling, the reason we use styled-components. What are the benefits of using this pattern?

I would like to discuss more about it. These were my primary feedback.
Thank you 😄

@jorgearturonh
Copy link
Contributor

jorgearturonh commented May 3, 2020

Hi @raikusy, I've been using this library for a while, you indeed can use styled-components and props styles simultaneously. If styles props are a problem you could create a separate .js file with the props as example

const divProps = {
       bg: ´#fff´,
       display: {xs: 'none', md: 'flex'}
 }
<Div ...divProps/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants