Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenMetrics #609

Closed
joe-elliott opened this issue Dec 9, 2020 · 6 comments
Closed

Add support for OpenMetrics #609

joe-elliott opened this issue Dec 9, 2020 · 6 comments

Comments

@joe-elliott
Copy link

The official go and python clients already support OM and the Ruby client has a running issue tracking progress.

The Java client is in wide use and it would benefit the Prometheus ecosystem for it to also support OM.

@brian-brazil
Copy link
Contributor

I'm already working on this.

@berkus
Copy link

berkus commented Mar 11, 2022

Hmm, PR link?

@fstab
Copy link
Member

fstab commented Mar 12, 2022

What's missing? OpenMetrics support is available since a long time. If you don't see it, it's likely because OM format is only produced if you request with the OM HTTP header:

curl -H 'Accept: application/openmetrics-text; version=1.0.0; charset=utf-8' http://localhost:8080/metrics

@berkus
Copy link

berkus commented Mar 14, 2022

Oh, thanks @fstab

I basically wanted to look into the java implementation, hence asked for a PR link. If you could point into the section of the code that implements openmetrics specifically that'd be helpful as well.

@fstab
Copy link
Member

fstab commented Mar 14, 2022

You can just search for an OpenMetrics type, like Info.

@berkus
Copy link

berkus commented Mar 27, 2022

Thank you, will try that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants