Remove flexible label support from Rack middleware #111
Milestone
Comments
Sinjo
pushed a commit
that referenced
this issue
May 3, 2019
We decided in #111 that the current interface for this is confusing to the point where it's more trouble than it's worth. The alternatives we came up with result in the middleware doing almost nothing and delegating to user-provided lambdas. Since we're pre-1.0, we're removing this in the belief that if it turns out to be a widely-requested feature, we can come up with something better. Leaving this implementation in would commit us to an interface we don't like. Fixes #111
Sinjo
pushed a commit
that referenced
this issue
May 3, 2019
We decided in #111 that the current interface for this is confusing to the point where it's more trouble than it's worth. The alternatives we came up with result in the middleware doing almost nothing and delegating to user-provided lambdas. Since we're pre-1.0, we're removing this in the belief that if it turns out to be a widely-requested feature, we can come up with something better. Leaving this implementation in would commit us to an interface we don't like. Fixes #111 Signed-off-by: Chris Sinjakli <[email protected]>
swalberg
added a commit
to swalberg/client_ruby
that referenced
this issue
May 27, 2019
I was trying to modify the path that's exported and didn't realize it was _just_ changed. The documentation in the example project still reflects the old way. Gave a short example of how I did it -- I realize subclassing a protected method is dangerous but there are no other hooks. FWIW my use case was that the default regular expressions did not cover my url structure and I needed to add another one. I did not need to add more labels.
swalberg
added a commit
to swalberg/client_ruby
that referenced
this issue
May 27, 2019
I was trying to modify the path that's exported and didn't realize it was _just_ changed. The documentation in the example project still reflects the old way. Gave a short example of how I did it -- I realize subclassing a protected method is dangerous but there are no other hooks. FWIW my use case was that the default regular expressions did not cover my url structure and I needed to add another one. I did not need to add more labels. Signed-off-by: Sean Walberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Supporting flexible labels in our out-the-box Rack middleware commits us to maintaining what is currently quite a confusing API.
@dmagliola discussed a few ways to make the API less weird, but they always resulted in the middleware accepting multiple lambdas for custom behaviour as arguments and having almost no behaviour provided out the box - sort of defeating the purpose!
We can always come back and add a better implementation of this functionality later, but it will be a pain to take this version of it away.
I’m in favour of only supporting our fixed set of labels in the Rack middleware we provide, and having a README section advising people to do their own thing if they want something more sophisticated.
The text was updated successfully, but these errors were encountered: