You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently labels are handled by being the first argument to all functions. This gives the incorrect impression that all metrics should labels (in reality most metrics don't have labels) and makes label-less use harder.
@brian-brazil this is now covered as part of the changes we made in PR #95. We require labels at creation time, they're no longer the first parameter, and the Child notion is implemented through the with_labels methods.
I'm going to close this issue due to this but feel free to reopen if you think there's still work to do on this.
Currently labels are handled by being the first argument to all functions. This gives the incorrect impression that all metrics should labels (in reality most metrics don't have labels) and makes label-less use harder.
This client should follow the structure laid out in https://prometheus.io/docs/instrumenting/writing_clientlibs/#labels
In addition the user should be required to specify all their label names at metric creation time.
The text was updated successfully, but these errors were encountered: