zfs: Allow space in dataset name #3186
Open
+136
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Khafateh <[email protected]>
khafatech
force-pushed
the
zfs-space-in-dataset
branch
from
d9a566b
to
f4b1f02
Compare
|
The e2e tests need updating; will fix. |
khafatech
changed the title
Signed-off-by: Mustafa Khafateh <[email protected]>
Signed-off-by: Mustafa Khafateh <[email protected]>
Signed-off-by: Mustafa Khafateh <[email protected]>
Signed-off-by: Mustafa Khafateh <[email protected]>
khafatech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@discordianfish
The zfs dataset name now gets parsed properly if it has spaces in it.
An ascii space character is allowed in a dataset according to entity_namecheck() in zfs code.
I also added a unit test to test for this case.
For unit and end-to-end tests, I added a new zpool fixture,
"pool3", a copy of"pool1"but with dataset name"pool3/dataset with space".Fixes #3170