chore!: adopt log/slog, drop go-kit/log #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like golangci-lint needs to be updated in CI -- the version used is too old to support the |
The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Other changes include: - bumps prometheus/{common,exporter-toolkit,client_golang} - removes linter configs for go-kit/log - enables sloglint - switches kingpin to use github import to avoid gopkg.in vs github.com import conflicts with promethues/common/promslog/flag pkg - updates version collector to use the new pkg from client_golang and get off old pkg from common Signed-off-by: TJ Hoplock <[email protected]>
tjhop
force-pushed
the
chore/adopt-slog
branch
from
d3529ff
to
cee021a
Compare
SuperQ
reviewed
Nov 10, 2024
SuperQ
approved these changes
Nov 10, 2024
Signed-off-by: TJ Hoplock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore!: adopt log/slog, drop go-kit/log
The bulk of this change set was automated by the following script which
is being used to aid in converting the various exporters/projects to use
slog:
https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434
Other changes include:
import conflicts with promethues/common/promslog/flag pkg
get off old pkg from common