Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should run benchmarks and compare on all PR's #326

Open
glightfoot opened this issue Jul 28, 2020 · 2 comments
Open

CI should run benchmarks and compare on all PR's #326

glightfoot opened this issue Jul 28, 2020 · 2 comments

Comments

@glightfoot
Copy link
Contributor

Now that we have more benchmarks, it would be good if CI ran benchmarks on all PR's and commented with the result and the benchcmp/benchstat output. Not sure how other projects are doing this

@matthiasr
Copy link
Contributor

We are using the common build infrastructure (Makefile) from github.com/prometheus/common without much extra. I'm willing to give this a try – my main worry is that it makes PRs too noisy to work with but we will see.

Is there prior art for this that we can lean on?

@glightfoot
Copy link
Contributor Author

It looks like there is some benchmarking stuff in prometheus/test-infra https://github.com/prometheus/test-infra/tree/master/funcbench.

Yeah it could definitely get noisey. Funcbench seems to support using github comments to trigger a run, so that would probably be good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants