Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional architectures to pylace build #51

Open
schmidmt opened this issue Mar 14, 2023 · 6 comments
Open

Add additional architectures to pylace build #51

schmidmt opened this issue Mar 14, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@schmidmt
Copy link
Contributor

After polars is updated, we need to add x86 builds back to the automated builds in ci.

@schmidmt schmidmt added the enhancement New feature or request label Mar 14, 2023
@schmidmt schmidmt self-assigned this Mar 14, 2023
@Swandog
Copy link
Contributor

Swandog commented Mar 14, 2023

Do you mean non-x86 builds?

@schmidmt
Copy link
Contributor Author

You're correct. Though x86 jobs weren't failing due to explicit references to x86_64 methods.

@Swandog
Copy link
Contributor

Swandog commented Mar 14, 2023

I'm not sure if there's a good solution for doing this in CI. GitHub doesn't have ARM runners available. And they also specifically suggest you DON'T use self-hosted runners for public projects, for security reasons.

We can still build the ARM packages, just not run them. GitHub says they will have ARM runners at some point; I don't know if this is worth working on until then

@Swandog
Copy link
Contributor

Swandog commented Mar 14, 2023

This is what I'm basing my view on MacOS ARM runners on:

#github/roadmap#528

@BaxterEaves
Copy link
Contributor

Is this still an issue?

@Swandog
Copy link
Contributor

Swandog commented Jan 29, 2024

I don't think the original issue is. We are still not running CI on ARM builds, but we probably won't be unless/until GitHub starts offering free ARM CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants