From 73e134eb6bd258fe6aaaa27573a4859c524c36e1 Mon Sep 17 00:00:00 2001
From: Baxter Eaves <bax@redpoll.ai>
Date: Wed, 31 Jan 2024 09:29:05 -0600
Subject: [PATCH] Make pylace default transitions hit everything

I went in to all a slice row kernel in sams, but found that `sams`
didn't update state_alpha and `fast` didn't update anything but the row
and column reassignment. Fixed.
---
 CHANGELOG.md         |  2 ++
 pylace/lace/utils.py | 14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3005e63c..44601035 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 - Initializing an engine with a codebook that has a different number of rows than the data will result in an error instead of printing a bunch on nonsense.
+- Pylace default transition sets didn't hit all required transitions
+- Typo in pylace internal `Dimension` class
 
 ## [python-0.6.0] - 2024-01-23
 
diff --git a/pylace/lace/utils.py b/pylace/lace/utils.py
index 0b000cb0..d1ff726d 100644
--- a/pylace/lace/utils.py
+++ b/pylace/lace/utils.py
@@ -17,7 +17,7 @@
 
 class Dimension:
     Rows = 0
-    Colums = 1
+    Columns = 1
 
 
 FN_IS_SYMMETRIC = {
@@ -28,8 +28,8 @@ class Dimension:
 
 
 FN_DIMENSION = {
-    "mi": Dimension.Colums,
-    "depprob": Dimension.Colums,
+    "mi": Dimension.Columns,
+    "depprob": Dimension.Columns,
     "rowsim": Dimension.Rows,
 }
 
@@ -132,10 +132,10 @@ def infer_column_metadata(
         StateTransition.view_alphas(),
         StateTransition.row_assignment(RowKernel.sams()),
         StateTransition.view_alphas(),
+        StateTransition.row_assignment(RowKernel.slice()),
         StateTransition.component_parameters(),
         StateTransition.column_assignment(ColumnKernel.gibbs()),
-        StateTransition.column_assignment(ColumnKernel.slice()),
-        StateTransition.view_alphas(),
+        StateTransition.state_alpha(),
         StateTransition.feature_priors(),
     ],
     "flat": [
@@ -151,8 +151,12 @@ def infer_column_metadata(
         StateTransition.feature_priors(),
     ],
     "fast": [
+        StateTransition.view_alphas(),
         StateTransition.row_assignment(RowKernel.slice()),
+        StateTransition.component_parameters(),
+        StateTransition.feature_priors(),
         StateTransition.column_assignment(ColumnKernel.slice()),
+        StateTransition.state_alpha(),
     ],
 }