Support for rootless containers #204
Conversation
This commit allows preserving file owner information as `user.rootlesscontainers` xattr values. Please refer to https://rootlesscontaine.rs/ for further information. Signed-off-by: Akihiro Suda <[email protected]>
… build on fedora. Signed-off-by: Max Goltzsche <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
|
thanks |
|
I think rootless-containers#2 needs to be fixed |
|
also needs rootless-containers@2a2a37e |
…iners/runrootless Signed-off-by: Sven Dowideit <[email protected]>
| @@ -10,7 +10,7 @@ Buildroot : %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) | |||
| Prefix : /usr | |||
| Name : proot | |||
|
|
|||
| BuildRequires: libtalloc-devel | |||
| BuildRequires: libtalloc-devel, protobuf-c-devel, libattr-devel | |||
There was a problem hiding this comment.
These should be declared as optional dependencies. Not sure off the top of my head how to do that with RPM.
| @@ -0,0 +1,18 @@ | |||
| FROM debian:9 AS build | |||
There was a problem hiding this comment.
See Dockerfile structure, https://github.com/proot-me/proot/tree/test-docker
| @@ -1,6 +1,8 @@ | |||
| # If you want to build outside of the source tree, use the -f option: | |||
| # make -f ${SOMEWHERE}/proot/src/GNUmakefile | |||
|
|
|||
| PERSISTENT_CHOWN := 1 | |||
There was a problem hiding this comment.
I think this should be disabled by default.
|
|
||
| CARE_LDFLAGS = -larchive | ||
| CARE_LDFLAGS = -larchive -static |
There was a problem hiding this comment.
This should not be static by default.
| @@ -0,0 +1,202 @@ | |||
|
|
|||
There was a problem hiding this comment.
This and all other accompanying files should be moved under src/extention/.
| @@ -0,0 +1,13 @@ | |||
| # rootlesscontainers.proto | |||
There was a problem hiding this comment.
This should be rewritten to use reStructuredText.
| @@ -0,0 +1,103 @@ | |||
| /* Generated by the protocol buffer compiler. DO NOT EDIT! */ | |||
There was a problem hiding this comment.
Auto-generated files should not be included in the repository, (See: #198).
| @@ -0,0 +1,86 @@ | |||
| /* Generated by the protocol buffer compiler. DO NOT EDIT! */ | |||
| @@ -20,6 +20,7 @@ | |||
| * 02110-1301 USA. | |||
| */ | |||
|
|
|||
| #include <stdio.h> | |||
There was a problem hiding this comment.
This is all from #130, isn't it?
|
Thanks |
oxr463
changed the title
I'm trying out some things with rootless namespace vs no-namespace container usage, and wonder if @AkihiroSuda 's fork is necessary, or if these changes can be merged
:)
I've basically naively rebased - so feel free to tell me off.