You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Schemas with reserved inside a group fail parsing. For example;
message MyMessage {
repeated group EntryResponse = 1 {
optional string id = 2;
reserved 3;
optional string info = 4;
}
}
Will fail with error:
Error: illegal token 'reserved' (test.proto, line 4)
at illegal (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:96:16)
at parseGroup_block (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:490:27)
at ifBlock (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:311:17)
at parseGroup (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:455:9)
at parseField (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:381:13)
at parseType_block (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:341:21)
at ifBlock (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:311:17)
at parseType (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:329:9)
at parseCommon (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:282:17)
at parse (/Users/ad/Desktop/protob/node_modules/protobufjs/src/parse.js:866:21)
The fix seems pretty simple, just to add an handle for it in parseGroup. Did it locally and was able to load properly the proto file.
Opened a PR so you could review: #2058
Thanks
The text was updated successfully, but these errors were encountered:
Schemas with
reserved
inside a group fail parsing. For example;Will fail with error:
The fix seems pretty simple, just to add an handle for it in
parseGroup
. Did it locally and was able to load properly the proto file.Opened a PR so you could review: #2058
Thanks
The text was updated successfully, but these errors were encountered: