Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate dependency id (name + org) matches the manifest in a repo #19

Open
jefferyshivers opened this issue Jul 4, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jefferyshivers
Copy link
Contributor

Currently, we do validate that a manifest exists in a given repo when it is a dependency. But we don't validate that the given id is actually matched with the properties in the manifest.

For example, running protop sync in Project B currently works without any errors/warnings that the id of a dependency (Project A) doesn't match what's in the manifest:

Project A's manifest:

{ "name": "foo", "organization": "bar" }

Project B's manifest:

{ 
  "dependencies":  { 
    "invalid/test": "gh:foo/bar"
  }
}

We should probably at least provide a warning log that there is a mismatch, and optionally a flag (e.g. protop sync --valid) to exit with an error.

@jefferyshivers jefferyshivers added bug Something isn't working good first issue Good for newcomers labels Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant