Skip to content

Commit 12c60c9

Browse files
committed
Add enum names before items
Signed-off-by: Victor Gomes <[email protected]>
1 parent c4d7bb0 commit 12c60c9

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

src/v8/v8.cc

+23-23
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,13 @@ class V8 : public WasmVm {
140140

141141
static std::string printValue(const wasm::Val &value) {
142142
switch (value.kind()) {
143-
case wasm::I32:
143+
case wasm::ValKind::I32:
144144
return std::to_string(value.get<uint32_t>());
145-
case wasm::I64:
145+
case wasm::ValKind::I64:
146146
return std::to_string(value.get<uint64_t>());
147-
case wasm::F32:
147+
case wasm::ValKind::F32:
148148
return std::to_string(value.get<float>());
149-
case wasm::F64:
149+
case wasm::ValKind::F64:
150150
return std::to_string(value.get<double>());
151151
default:
152152
return "unknown";
@@ -170,17 +170,17 @@ static std::string printValues(const wasm::Val values[], size_t size) {
170170

171171
static const char *printValKind(wasm::ValKind kind) {
172172
switch (kind) {
173-
case wasm::I32:
173+
case wasm::ValKind::I32:
174174
return "i32";
175-
case wasm::I64:
175+
case wasm::ValKind::I64:
176176
return "i64";
177-
case wasm::F32:
177+
case wasm::ValKind::F32:
178178
return "f32";
179-
case wasm::F64:
179+
case wasm::ValKind::F64:
180180
return "f64";
181-
case wasm::ANYREF:
181+
case wasm::ValKind::ANYREF:
182182
return "anyref";
183-
case wasm::FUNCREF:
183+
case wasm::ValKind::FUNCREF:
184184
return "funcref";
185185
default:
186186
return "unknown";
@@ -229,11 +229,11 @@ template <typename T> wasm::Val makeVal(T t) { return wasm::Val::make(t); }
229229
template <> wasm::Val makeVal(Word t) { return wasm::Val::make(static_cast<uint32_t>(t.u64_)); }
230230

231231
template <typename T> constexpr auto convertArgToValKind();
232-
template <> constexpr auto convertArgToValKind<Word>() { return wasm::I32; };
233-
template <> constexpr auto convertArgToValKind<uint32_t>() { return wasm::I32; };
234-
template <> constexpr auto convertArgToValKind<int64_t>() { return wasm::I64; };
235-
template <> constexpr auto convertArgToValKind<uint64_t>() { return wasm::I64; };
236-
template <> constexpr auto convertArgToValKind<double>() { return wasm::F64; };
232+
template <> constexpr auto convertArgToValKind<Word>() { return wasm::ValKind::I32; };
233+
template <> constexpr auto convertArgToValKind<uint32_t>() { return wasm::ValKind::I32; };
234+
template <> constexpr auto convertArgToValKind<int64_t>() { return wasm::ValKind::I64; };
235+
template <> constexpr auto convertArgToValKind<uint64_t>() { return wasm::ValKind::I64; };
236+
template <> constexpr auto convertArgToValKind<double>() { return wasm::ValKind::F64; };
237237

238238
template <typename T, std::size_t... I>
239239
constexpr auto convertArgsTupleToValTypesImpl(std::index_sequence<I...> /*comptime*/) {
@@ -352,7 +352,7 @@ bool V8::link(std::string_view /*debug_name*/) {
352352

353353
switch (import_type->kind()) {
354354

355-
case wasm::EXTERN_FUNC: {
355+
case wasm::ExternKind::EXTERN_FUNC: {
356356
auto it = host_functions_.find(std::string(module) + "." + std::string(name));
357357
if (it == host_functions_.end()) {
358358
fail(FailState::UnableToInitializeCode,
@@ -375,15 +375,15 @@ bool V8::link(std::string_view /*debug_name*/) {
375375
imports.push_back(func);
376376
} break;
377377

378-
case wasm::EXTERN_GLOBAL: {
378+
case wasm::ExternKind::EXTERN_GLOBAL: {
379379
// TODO(PiotrSikora): add support when/if needed.
380380
fail(FailState::UnableToInitializeCode,
381381
"Failed to load Wasm module due to a missing import: " + std::string(module) + "." +
382382
std::string(name));
383383
return false;
384384
} break;
385385

386-
case wasm::EXTERN_MEMORY: {
386+
case wasm::ExternKind::EXTERN_MEMORY: {
387387
assert(memory_ == nullptr);
388388
auto type = wasm::MemoryType::make(import_type->memory()->limits());
389389
if (type == nullptr) {
@@ -396,7 +396,7 @@ bool V8::link(std::string_view /*debug_name*/) {
396396
imports.push_back(memory_.get());
397397
} break;
398398

399-
case wasm::EXTERN_TABLE: {
399+
case wasm::ExternKind::EXTERN_TABLE: {
400400
assert(table_ == nullptr);
401401
auto type =
402402
wasm::TableType::make(wasm::ValType::make(import_type->table()->element()->kind()),
@@ -435,16 +435,16 @@ bool V8::link(std::string_view /*debug_name*/) {
435435

436436
switch (export_type->kind()) {
437437

438-
case wasm::EXTERN_FUNC: {
438+
case wasm::ExternKind::EXTERN_FUNC: {
439439
assert(export_item->func() != nullptr);
440440
module_functions_.insert_or_assign(std::string(name), export_item->func()->copy());
441441
} break;
442442

443-
case wasm::EXTERN_GLOBAL: {
443+
case wasm::ExternKind::EXTERN_GLOBAL: {
444444
// TODO(PiotrSikora): add support when/if needed.
445445
} break;
446446

447-
case wasm::EXTERN_MEMORY: {
447+
case wasm::ExternKind::EXTERN_MEMORY: {
448448
assert(export_item->memory() != nullptr);
449449
assert(memory_ == nullptr);
450450
memory_ = exports[i]->memory()->copy();
@@ -453,7 +453,7 @@ bool V8::link(std::string_view /*debug_name*/) {
453453
}
454454
} break;
455455

456-
case wasm::EXTERN_TABLE: {
456+
case wasm::ExternKind::EXTERN_TABLE: {
457457
// TODO(PiotrSikora): add support when/if needed.
458458
} break;
459459
}

0 commit comments

Comments
 (0)