Skip to content

Commit 7916640

Browse files
committed
remove unnecessary proto from the SDK
Signed-off-by: wangbaiping/wbpcode <[email protected]>
1 parent 4f53e7a commit 7916640

16 files changed

+6
-25512
lines changed

BUILD

+1-41
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_proto_library")
2-
load("@rules_proto//proto:defs.bzl", "proto_library")
1+
load("@rules_cc//cc:defs.bzl", "cc_library")
32

43
licenses(["notice"]) # Apache 2
54

@@ -45,69 +44,30 @@ cc_library(
4544
visibility = ["//visibility:public"],
4645
)
4746

48-
cc_proto_library(
49-
name = "proxy_wasm_intrinsics_cc_proto",
50-
deps = [":proxy_wasm_intrinsics_proto"],
51-
)
52-
53-
proto_library(
54-
name = "proxy_wasm_intrinsics_proto",
55-
srcs = ["proxy_wasm_intrinsics.proto"],
56-
deps = [
57-
"@com_google_protobuf//:any_proto",
58-
"@com_google_protobuf//:duration_proto",
59-
"@com_google_protobuf//:empty_proto",
60-
"@com_google_protobuf//:struct_proto",
61-
],
62-
)
63-
6447
# include lite protobuf support
6548
cc_library(
6649
name = "proxy_wasm_intrinsics_lite",
67-
hdrs = ["proxy_wasm_intrinsics_lite.h"],
6850
copts = ["-std=c++17"],
6951
defines = ["PROXY_WASM_PROTOBUF_LITE"],
7052
visibility = ["//visibility:public"],
7153
deps = [
7254
":proxy_wasm_intrinsics",
73-
":proxy_wasm_intrinsics_lite_cc_proto",
7455
"@com_google_protobuf//:protobuf_lite",
7556
],
7657
)
7758

7859
# include full protobuf support
7960
cc_library(
8061
name = "proxy_wasm_intrinsics_full",
81-
hdrs = ["proxy_wasm_intrinsics_full.h"],
8262
copts = ["-std=c++17"],
8363
defines = ["PROXY_WASM_PROTOBUF_FULL"],
8464
visibility = ["//visibility:public"],
8565
deps = [
8666
":proxy_wasm_intrinsics",
87-
":proxy_wasm_intrinsics_cc_proto",
8867
"@com_google_protobuf//:protobuf",
8968
],
9069
)
9170

92-
cc_proto_library(
93-
name = "proxy_wasm_intrinsics_lite_cc_proto",
94-
deps = [":proxy_wasm_intrinsics_lite_proto"],
95-
)
96-
97-
proto_library(
98-
name = "proxy_wasm_intrinsics_lite_proto",
99-
srcs = [
100-
"proxy_wasm_intrinsics_lite.proto",
101-
"struct_lite.proto",
102-
],
103-
deps = [
104-
"@com_google_protobuf//:any_proto",
105-
"@com_google_protobuf//:duration_proto",
106-
"@com_google_protobuf//:empty_proto",
107-
"@com_google_protobuf//:struct_proto",
108-
],
109-
)
110-
11171
filegroup(
11272
name = "proxy_wasm_intrinsics_js",
11373
srcs = [

Dockerfile-sdk

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ubuntu:noble
22

33
COPY *.sh /
4-
COPY *.cc *.h *.js *.proto Makefile* /sdk/
4+
COPY *.cc *.h *.js Makefile* /sdk/
55

66
RUN ./sdk_container.sh

Makefile

+2-12
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,10 @@ endif
77
PROTOBUF ?= none
88
ifeq ($(PROTOBUF), full)
99
PROTO_DEPS := protobuf
10-
PROTO_OPTS := -DPROXY_WASM_PROTOBUF_FULL=1 \
11-
${PROXY_WASM_CPP_SDK}/proxy_wasm_intrinsics.pb.cc
10+
PROTO_OPTS := -DPROXY_WASM_PROTOBUF_FULL=1
1211
else ifeq ($(PROTOBUF), lite)
1312
PROTO_DEPS := protobuf-lite
14-
PROTO_OPTS := -DPROXY_WASM_PROTOBUF_LITE=1 \
15-
${PROXY_WASM_CPP_SDK}/proxy_wasm_intrinsics_lite.pb.cc \
16-
${PROXY_WASM_CPP_SDK}/struct_lite.pb.cc
13+
PROTO_OPTS := -DPROXY_WASM_PROTOBUF_LITE=1
1714
else
1815
PROTO_DEPS :=
1916
PROTO_OPTS :=
@@ -48,10 +45,3 @@ debug-deps:
4845

4946
clean:
5047
rm *.wasm
51-
52-
# NOTE: How to regenerate .pb.h and .pb.cc files for a protobuf update:
53-
# - download + extract protobuf release (currently v26.1)
54-
# - regenerate:
55-
# ./bin/protoc --cpp_out=../ -I../ -Iinclude/google/protobuf/ ../struct_lite.proto
56-
# ./bin/protoc --cpp_out=../ -I../ -Iinclude/google/protobuf/ ../proxy_wasm_intrinsics_lite.proto
57-
# ./bin/protoc --cpp_out=../ -I../ -Iinclude/google/protobuf/ ../proxy_wasm_intrinsics.proto

example/http_proto_example.cc

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15+
#include "google/protobuf/struct.pb.h"
16+
1517
#include "proxy_wasm_intrinsics.h"
1618

1719
class MyRootContext : public RootContext {

proxy_wasm_intrinsics.h

-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,8 @@
3838
#include "proxy_wasm_externs.h"
3939
#ifdef PROXY_WASM_PROTOBUF_FULL
4040
#define PROXY_WASM_PROTOBUF 1
41-
#include "proxy_wasm_intrinsics.pb.h"
4241
#endif
4342
#ifdef PROXY_WASM_PROTOBUF_LITE
4443
#define PROXY_WASM_PROTOBUF 1
45-
#include "proxy_wasm_intrinsics_lite.pb.h"
4644
#endif
4745
#include "proxy_wasm_api.h"

0 commit comments

Comments
 (0)