From 2b02240c32dc9e2723d44b9d58bd8f624c464c52 Mon Sep 17 00:00:00 2001 From: Rob Hoes Date: Wed, 4 Dec 2024 11:30:23 +0000 Subject: [PATCH] Remove references to perftest Signed-off-by: Rob Hoes --- ocaml/libs/http-lib/http_client.ml | 6 ------ ocaml/libs/http-lib/http_client.mli | 3 --- quality-gate.sh | 6 +++--- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/ocaml/libs/http-lib/http_client.ml b/ocaml/libs/http-lib/http_client.ml index 5cb67212bcc..fed8f5f7780 100644 --- a/ocaml/libs/http-lib/http_client.ml +++ b/ocaml/libs/http-lib/http_client.ml @@ -200,9 +200,6 @@ let response_of_fd ?(use_fastpath = false) fd = __FUNCTION__ (Printexc.to_string e) ; None -(** See perftest/tests.ml *) -let last_content_length = ref 0L - let http_rpc_recv_response use_fastpath error_msg fd = match response_of_fd ~use_fastpath fd with | None -> @@ -212,9 +209,6 @@ let http_rpc_recv_response use_fastpath error_msg fd = | ("401" | "403" | "500") as http_code -> raise (Http_error (http_code, error_msg)) | "200" -> - Option.iter - (fun x -> last_content_length := x) - response.Http.Response.content_length ; response | code -> raise (Http_request_rejected (Printf.sprintf "%s: %s" code error_msg)) diff --git a/ocaml/libs/http-lib/http_client.mli b/ocaml/libs/http-lib/http_client.mli index 68d65649e3c..3d9b6591d5f 100644 --- a/ocaml/libs/http-lib/http_client.mli +++ b/ocaml/libs/http-lib/http_client.mli @@ -40,6 +40,3 @@ val rpc : (** [rpc fd request body f] marshals the HTTP request represented by [request] and [body] through file descriptor [fd] and then applies the response to [f]. On failure an exception is thrown. *) - -val last_content_length : int64 ref -(** See perftest/tests.ml *) diff --git a/quality-gate.sh b/quality-gate.sh index b72ca099aa7..6255ce0575e 100755 --- a/quality-gate.sh +++ b/quality-gate.sh @@ -26,9 +26,9 @@ verify-cert () { mli-files () { N=497 - # do not count ml files from the tests in ocaml/{tests/perftest/quicktest} - MLIS=$(git ls-files -- '**/*.mli' | grep -vE "ocaml/tests|ocaml/perftest|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;) - MLS=$(git ls-files -- '**/*.ml' | grep -vE "ocaml/tests|ocaml/perftest|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;) + # do not count ml files from the tests in ocaml/{tests/quicktest} + MLIS=$(git ls-files -- '**/*.mli' | grep -vE "ocaml/tests|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;) + MLS=$(git ls-files -- '**/*.ml' | grep -vE "ocaml/tests|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;) num_mls_without_mlis=$(comm -23 <(sort <<<"$MLS") <(sort <<<"$MLIS") | wc -l) if [ "$num_mls_without_mlis" -eq "$N" ]; then echo "OK counted $num_mls_without_mlis .ml files without an .mli"