Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage condition #2

Open
Yakimych opened this issue Aug 7, 2021 · 1 comment
Open

Stage condition #2

Yakimych opened this issue Aug 7, 2021 · 1 comment

Comments

@Yakimych
Copy link
Contributor

Yakimych commented Aug 7, 2021

I am currently testing Finelines out with one of my small-ish Azure Pipelines setups, and am likely to come up with a list of questions along the way. The first one is about condition that seems to be missing on stage, but does exist on Task: https://github.com/psfinaki/Finelines/blob/main/src/Finelines/Tasks/Task.fs#L6. Do we just add a "Condition" string to the Stage too, or would it not work the same way here?

A more general question about the "condition" is whether the future plans are to create a DSL for it, or to keep it as a string. I've noticed that you have mentioned this in the Motivation section:

All the attempts to build programming experience (like variables or conditions) on top of it are obstructions and only cause pain.

However, those pains are not addressed if we use a string for condition anyway.

@psfinaki
Copy link
Owner

psfinaki commented Aug 7, 2021

Hi @Yakimych 👋

and am likely to come up with a list of questions

Please do!

Do we just add a "Condition" string to the Stage too, or would it not work the same way here?

Will not work just yet, but I've just created a PR for that, take a look :)

A more general question about the "condition" is whether the future plans are to create a DSL for it, or to keep it as a string.

It would be absolutely awesome to have a DSL for that and will completely follow the spirit of the project. The thing is that creating a DSL is a bit harder than creating things like discriminated union for virtual machine names so it might need some thinking and design :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants