Unitselection #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting a unit test failure in marytts.documentation.MaryDocumentationTest; that class has a lot of commented out stuff -- maybe you could clean it up a bit? The underlying failure is however related to the IT failure we discussed. |
added 28 commits
March 10, 2015 15:08
…ranch which were relevant to helping filter out the unit selection package. Also formatted the code to eclipse style and added the google gson to pom
…ationsFFR from unit selection package
copied cart and features packages into new maven module marytts-unitselection (but also still in runtime) moved Target, HalfPhoneTarget,DiphoneTarget and TargetFeatureComputer from unitselection.select to features package moved feature file readers from unitselection.data to features still has compile errors
…electionVoice to be completely omitted from runtime
purgatory reorganised into two sub folders, runtime and builder - copying their folder hierarchies
…ser list in marybase.config
…red branch I didn't realise were needed. on a side note, this is what i have not taken from his branch and thus must still be committed in: -timelineTest.bin -all files related to exceptions showing actual costs fix -> they need to be formatted as they are causing conflicts -also, although it has been added, the DocumentTest class needs to be cleaned
added 3 commits
March 10, 2015 15:08
…ed Hamcrest dependencies to Hamcrest-integration. Hamcrest developers advise against using Hamcrest-all. The maven dependency order for using hamcrest and junit also seem to rely on hamcrest coming BEFORE junit. Also looked at implementing a mocked voice for the integration test using mockito, however it seems a real voice is needed to test.
…sis configs in MaryConfig. NOTE: MaryConfig.checkConsistency() is never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.