Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection event listener registration error #5

Open
emarteca opened this issue Dec 2, 2019 · 0 comments
Open

connection event listener registration error #5

emarteca opened this issue Dec 2, 2019 · 0 comments

Comments

@emarteca
Copy link

emarteca commented Dec 2, 2019

Hi all, I've been working on a tool to identify instances of events registered to the wrong object in uses of some JavaScript event-driven APIs, as part of a research project.
The tool flagged line 84 in static/js/front.js, on the registration of the “connection” event.

The reason I believe this is an error is as follows (from looking at the socket.io-client API documentation, particularly https://socket.io/docs/client-api/#Socket):
Variable s refers to an object of type socket.io-client.Socket, as initialized by a call to new io.Socket on line 78. “connection” is an event on the server, and not on the Socket itself.
The Socket has an event "connect", so my guess is that the code here should instead be "s.on(connect, ..."

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant