Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to fix this let TODO #134

Open
guilhermebodin opened this issue Apr 12, 2023 · 2 comments
Open

We need to fix this let TODO #134

guilhermebodin opened this issue Apr 12, 2023 · 2 comments

Comments

@guilhermebodin
Copy link
Member

guilhermebodin commented Apr 12, 2023

we should get rid of this TODO

         for i in first_relative_stage:(stage_total+1)
                # NOTE: This 'let' statement was introduced to dodge naming clashes.
                # It is also a good practice for variables who live inside loops.
                # TODO: Rename variables to better adhere to their meanings.
                let offset = read(ioh, Int32)
                    offsets[i-first_relative_stage+1] = offset
                    
                    if i > first_relative_stage
                        number_blocks[i-first_relative_stage] = offset - offsets[i-first_relative_stage]
                    end
                end
            end
@pedroripper
Copy link
Member

I can remove it in #128 and turn it into an issue

@guilhermebodin
Copy link
Member Author

no, you should open a new PR for this. Let's not accumulate changes in PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants