simplifybooleanreturn.md

Simplify boolean return

org.openrewrite.java.cleanup.SimplifyBooleanReturn

Simplifies Boolean expressions by removing redundancies, e.g.: a && true simplifies to a.

Tags

• RSPEC-1126

Source

GitHub, Issue Tracker, Maven Central

• groupId: org.openrewrite
• artifactId: rewrite-java
• version: 8.1.3

Example

{% tabs %} {% tab title="A.java" %}

Before

{% code title="A.java" %}

public class A {
    boolean ifNoElse() {
        if (isOddMillis()) {
            return true;
        }
        return false;
    }

    static boolean isOddMillis() {
        boolean even = System.currentTimeMillis() % 2 == 0;
        if (even == true) {
            return false;
        }
        else {
            return true;
        }
    }
}

{% endcode %}

After

{% code title="A.java" %}

public class A {
    boolean ifNoElse() {
        return isOddMillis();
    }

    static boolean isOddMillis() {
        boolean even = System.currentTimeMillis() % 2 == 0;
        return !(even == true);
    }
}

{% endcode %}

{% endtab %} {% tab title="Diff" %} {% code %}

--- A.java
+++ A.java
@@ -3,4 +3,1 @@
public class A {
    boolean ifNoElse() {
-       if (isOddMillis()) {
-           return true;
-       }
-       return false;
+       return isOddMillis();
    }
@@ -11,6 +8,1 @@
    static boolean isOddMillis() {
        boolean even = System.currentTimeMillis() % 2 == 0;
-       if (even == true) {
-           return false;
-       }
-       else {
-           return true;
-       }
+       return !(even == true);
    }

{% endcode %} {% endtab %} {% endtabs %}

Usage

This recipe has no required configuration parameters and comes from a rewrite core library. It can be activated directly without adding any dependencies. {% tabs %} {% tab title="Gradle" %} {% code title="build.gradle" %}

plugins {
    id("org.openrewrite.rewrite") version("6.1.4")
}

rewrite {
    activeRecipe("org.openrewrite.java.cleanup.SimplifyBooleanReturn")
}

repositories {
    mavenCentral()
}

{% endcode %} {% endtab %} {% tab title="Maven POM" %} {% code title="pom.xml" %}

<project>
  <build>
    <plugins>
      <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>5.2.4</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.java.cleanup.SimplifyBooleanReturn</recipe>
          </activeRecipes>
        </configuration>
      </plugin>
    </plugins>
  </build>
</project>

{% endcode %} {% endtab %}

{% tab title="Maven Command Line" %} You will need to have Maven installed on your machine before you can run the following command. {% code title="shell" %}

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.activeRecipes=org.openrewrite.java.cleanup.SimplifyBooleanReturn

{% endcode %} {% endtab %} {% endtabs %}

Contributors

• Jonathan Schnéider
• Aaron Gershman
• Josh Soref
• Greg Adams
• Knut Wannheden

See how this recipe works across multiple open-source repositories

The community edition of the Moderne platform enables you to easily run recipes across thousands of open-source repositories.

Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.