useexplicitcontains.md

Use AssertJ contains() on collections

org.openrewrite.java.testing.assertj.UseExplicitContains

Convert AssertJ assertThat(collection.contains(element)).isTrue() to assertThat(collection).contains(element) and assertThat(collection.contains(element)).isFalse() to assertThat(collection).doesNotContain(element).

Source

GitHub, Issue Tracker, Maven Central

• groupId: org.openrewrite.recipe
• artifactId: rewrite-testing-frameworks
• version: 2.0.2

Example

{% tabs %} {% tab title="MyTest.java" %}

Before

{% code title="MyTest.java" %}

import java.util.Collection;
import java.util.ArrayList;

import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

public class MyTest {

    @Test
    public void test() {
        Collection<String> collection = new ArrayList<>();
        collection.add("3");
        assertThat(collection.contains("3")).isTrue();
    }
}

{% endcode %}

After

{% code title="MyTest.java" %}

import java.util.Collection;
import java.util.ArrayList;

import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

public class MyTest {

    @Test
    public void test() {
        Collection<String> collection = new ArrayList<>();
        collection.add("3");
        assertThat(collection).contains("3");
    }
}

{% endcode %}

{% endtab %} {% tab title="Diff" %} {% code %}

--- MyTest.java
+++ MyTest.java
@@ -14,1 +14,1 @@
        Collection<String> collection = new ArrayList<>();
        collection.add("3");
-       assertThat(collection.contains("3")).isTrue();
+       assertThat(collection).contains("3");
    }

{% endcode %} {% endtab %} {% endtabs %}

Usage

This recipe has no required configuration options. It can be activated by adding a dependency on org.openrewrite.recipe:rewrite-testing-frameworks:2.0.2 in your build file or by running a shell command (in which case no build changes are needed): {% tabs %} {% tab title="Gradle" %} {% code title="build.gradle" %}

plugins {
    id("org.openrewrite.rewrite") version("6.1.4")
}

rewrite {
    activeRecipe("org.openrewrite.java.testing.assertj.UseExplicitContains")
}

repositories {
    mavenCentral()
}

dependencies {
    rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:2.0.2")
}

{% endcode %} {% endtab %} {% tab title="Maven POM" %} {% code title="pom.xml" %}

<project>
  <build>
    <plugins>
      <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>5.2.4</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.java.testing.assertj.UseExplicitContains</recipe>
          </activeRecipes>
        </configuration>
        <dependencies>
          <dependency>
            <groupId>org.openrewrite.recipe</groupId>
            <artifactId>rewrite-testing-frameworks</artifactId>
            <version>2.0.2</version>
          </dependency>
        </dependencies>
      </plugin>
    </plugins>
  </build>
</project>

{% endcode %} {% endtab %}

{% tab title="Maven Command Line" %} {% code title="shell" %} You will need to have Maven installed on your machine before you can run the following command.

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE \
  -Drewrite.activeRecipes=org.openrewrite.java.testing.assertj.UseExplicitContains

{% endcode %} {% endtab %} {% endtabs %}

Contributors

• Paolo Bizzarri
• Knut Wannheden
• Jonathan Schnéider
• Sam Snyder

See how this recipe works across multiple open-source repositories

The community edition of the Moderne platform enables you to easily run recipes across thousands of open-source repositories.

Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.