org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument
Instantiating a StringBuilder
or a StringBuffer
with a Character
results in the int
representation of the character being used for the initial size.
- RSPEC-1317
GitHub, Issue Tracker, Maven Central
- groupId: org.openrewrite.recipe
- artifactId: rewrite-static-analysis
- version: 1.0.1
{% tabs %} {% tab title="A.java" %}
{% code title="A.java" %}
class A {
StringBuffer buffer = new StringBuffer('a');
StringBuilder builder = new StringBuilder('a');
char notALiteral = 'c';
StringBuffer buffer = new StringBuffer(notALiteral);
}
{% endcode %}
{% code title="A.java" %}
class A {
StringBuffer buffer = new StringBuffer("a");
StringBuilder builder = new StringBuilder("a");
char notALiteral = 'c';
StringBuffer buffer = new StringBuffer(String.valueOf(notALiteral));
}
{% endcode %}
{% endtab %} {% tab title="Diff" %} {% code %}
--- A.java
+++ A.java
@@ -2,2 +2,2 @@
class A {
- StringBuffer buffer = new StringBuffer('a');
- StringBuilder builder = new StringBuilder('a');
+ StringBuffer buffer = new StringBuffer("a");
+ StringBuilder builder = new StringBuilder("a");
char notALiteral = 'c';
@@ -5,1 +5,1 @@
StringBuilder builder = new StringBuilder('a');
char notALiteral = 'c';
- StringBuffer buffer = new StringBuffer(notALiteral);
+ StringBuffer buffer = new StringBuffer(String.valueOf(notALiteral));
}
{% endcode %} {% endtab %} {% endtabs %}
This recipe has no required configuration options. It can be activated by adding a dependency on org.openrewrite.recipe:rewrite-static-analysis:1.0.1
in your build file or by running a shell command (in which case no build changes are needed):
{% tabs %}
{% tab title="Gradle" %}
{% code title="build.gradle" %}
plugins {
id("org.openrewrite.rewrite") version("6.1.4")
}
rewrite {
activeRecipe("org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument")
}
repositories {
mavenCentral()
}
dependencies {
rewrite("org.openrewrite.recipe:rewrite-static-analysis:1.0.1")
}
{% endcode %} {% endtab %} {% tab title="Maven POM" %} {% code title="pom.xml" %}
<project>
<build>
<plugins>
<plugin>
<groupId>org.openrewrite.maven</groupId>
<artifactId>rewrite-maven-plugin</artifactId>
<version>5.2.4</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument</recipe>
</activeRecipes>
</configuration>
<dependencies>
<dependency>
<groupId>org.openrewrite.recipe</groupId>
<artifactId>rewrite-static-analysis</artifactId>
<version>1.0.1</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>
</project>
{% endcode %} {% endtab %}
{% tab title="Maven Command Line" %} {% code title="shell" %} You will need to have Maven installed on your machine before you can run the following command.
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-static-analysis:RELEASE \
-Drewrite.activeRecipes=org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument
{% endcode %} {% endtab %} {% endtabs %}
The community edition of the Moderne platform enables you to easily run recipes across thousands of open-source repositories.
Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.