In this guide we'll look at using OpenRewrite to automatically refactor logging statements to take advantage of performance improvements offered by using slf4j
parameterized logging over String concatenation.
The ParameterizedLogging recipe has no required configuration options and can be activated directly after taking a dependency on rewrite-logging-frameworks in your build file:
{% tabs %} {% tab title="Gradle" %} {% code title="build.gradle" %}
plugins {
id("org.openrewrite.rewrite") version("6.1.8")
}
rewrite {
activeRecipe("org.openrewrite.java.logging.slf4j.ParameterizedLogging")
}
repositories {
mavenCentral()
}
dependencies {
rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:2.0.4"))
rewrite("org.openrewrite.recipe:rewrite-logging-frameworks")
}
{% endcode %} {% endtab %}
{% tab title="Maven" %} {% code title="pom.xml" %}
<project>
<build>
<plugins>
<plugin>
<groupId>org.openrewrite.maven</groupId>
<artifactId>rewrite-maven-plugin</artifactId>
<version>5.2.4</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.java.logging.slf4j.ParameterizedLogging</recipe>
</activeRecipes>
</configuration>
<dependencies>
<dependency>
<groupId>org.openrewrite.recipe</groupId>
<artifactId>rewrite-logging-frameworks</artifactId>
<version>2.0.4</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>
</project>
{% endcode %} {% endtab %} {% endtabs %}
At this point, you're ready to execute the migration by running mvn rewrite:run
or gradlew rewriteRun
. After running the migration you can inspect the results with git diff
(or equivalent), manually fix anything that wasn't able to be migrated automatically, and commit the results.
For the full list of changes, see the recipe's reference documentation.
{% tabs %} {% tab title="Example Class (Before)" %}
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class Example {
Logger logger = LoggerFactory.getLogger(Example.class);
void method(String name, double percent) {
logger.debug("Process [" + name + "] is at [" + percent * 100 + "%]");
}
void asInteger(String numberString) {
try {
Integer i = Integer.valueOf(numberString);
} catch (NumberFormatException ex) {
logger.warn("some big error: " + ex.getMessage(), ex);
}
}
}
{% endtab %}
{% tab title="Example Class (After)" %}
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class Example {
Logger logger = LoggerFactory.getLogger(Example.class);
void method(String name, double percent) {
logger.debug("Process [{}] is at [{}%]", name, percent * 100);
}
void asInteger(String numberString) {
try {
Integer i = Integer.valueOf(numberString);
} catch (NumberFormatException ex) {
logger.warn("some big error: {}", ex.getMessage(), ex);
}
}
}
{% endtab %} {% endtabs %}