Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklight 8 Upgrade #1289

Open
3 of 4 tasks
Smullz622 opened this issue Mar 29, 2024 · 1 comment · May be fixed by #1295
Open
3 of 4 tasks

Blacklight 8 Upgrade #1289

Smullz622 opened this issue Mar 29, 2024 · 1 comment · May be fixed by #1295
Assignees
@Smullz622

Comments

@Smullz622
Copy link
Contributor

Smullz622 commented Mar 29, 2024 •
edited
Loading

Breaking down the steps needed for us to move to BL8. The first three steps are a must, last one will require some additional thought.

  • upgrade rails to 7.x (point of interest that myaccount is also on 6.1)
  • upgrade BL to 7.36
  • resolve depreciation warnings
  • upgrade to BL 8/ handle remove advanced search gem

At this time, the blacklight_advanced_search gem does not have a stable release compatible with BL8. In order to upgrade to BL8, we have two main options: use gem v8.0.0.alpha (currently in use at Stanford) or remove gem entirely since BL has functionality to handle advanced search without the gem. The latter is the ideal since the last stable release of the gem was in 2020 & even the alpha was 2022. This is likely to be an ongoing problem. It will just be a matter of how long the other steps take/how much work will need to go into pulling the gem out whether we remove it now or wait until a later maintenance cycle.
@Smullz622 Smullz622 self-assigned this Apr 1, 2024
@Smullz622
Copy link
Contributor Author

Putting a hold on this for now but leaving notes here for when we resume

As of 5/30/24-

Outstanding upgrade problems:

  • availability does not show up in search results (does show up on individual record view)

    • The code for app/views/catalog/_index_availability.html.erb isn’t being called at all. Something is no longer being overridden causing the failure. I tried tracing back from index_availability and forward from search results but ran into the roadblocks below.
    • app/views/catalog/search_results.html.erb is still being called & calls _document_index but can’t figure out where that is on our end or BL (including BL 7.37)
    • app/views/catalog/_index_availability.html.erb is called from app/views/catalog/_index_default- cannot figure out where app/views/catalog/_index_default is being called on our end or BL (including BL 7.37)

  • bookmarks has an undefined method name error

  • share/email of individual record comes up blank rather than bringing up the pop up

@Smullz622 Smullz622 linked a pull request May 30, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Smullz622 Smullz622

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP upgrade to blacklight 8 psu-libraries/psulib_blacklight
1 participant
@Smullz622