Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the AdobePdf module from ScholarSphere #1638

Open
ajkiessl opened this issue Oct 28, 2024 · 0 comments
Open

Decouple the AdobePdf module from ScholarSphere #1638

ajkiessl opened this issue Oct 28, 2024 · 0 comments

Comments

@ajkiessl
Copy link
Collaborator

It might be useful to have this as its own gem so it can be used elsewhere. It should be pretty close to decoupling. Any place that invokes AccessibilityCheckResult.create! can be replaced with either the returned report or an error. File handling will likely need changed. The S3Handler module requires a FileResource, which binds it to ScholarSphere. Perhaps just handing it an S3 key, or file path would be better for decoupling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant