From 25f89c642e33c883ac0a6af8a5be569b47effb88 Mon Sep 17 00:00:00 2001 From: Pascal Thomet Date: Sat, 4 May 2024 07:24:57 +0200 Subject: [PATCH] cmake: some comments --- hello_imgui_cmake/hello_imgui_build_lib.cmake | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hello_imgui_cmake/hello_imgui_build_lib.cmake b/hello_imgui_cmake/hello_imgui_build_lib.cmake index 4ea07184..d4e47fb4 100644 --- a/hello_imgui_cmake/hello_imgui_build_lib.cmake +++ b/hello_imgui_cmake/hello_imgui_build_lib.cmake @@ -478,7 +478,7 @@ endfunction() ################################################################################################### function(him_sanity_checks) him_back_check_if_no_backend_option_chosen(no_backend_option_chosen) - _him_check_fetch_forbidden() # mset HELLOIMGUI_FETCH_FORBIDDEN + _him_check_fetch_forbidden() # may set HELLOIMGUI_FETCH_FORBIDDEN if (NOT WIN32) set(HELLOIMGUI_HAS_DIRECTX11 OFF CACHE BOOL "" FORCE) @@ -489,11 +489,8 @@ function(him_sanity_checks) endif() if (no_backend_option_chosen AND NOT HELLOIMGUI_USING_VCPKG_TOOLCHAIN) - # use SDL for emscripten and iOS - if (EMSCRIPTEN) - set(HELLOIMGUI_USE_SDL2 ON CACHE BOOL "" FORCE) - set(HELLOIMGUI_HAS_OPENGL3 ON CACHE BOOL "" FORCE) - elseif (IOS) + # use SDL for emscripten and iOS, GLFW for the rest + if (EMSCRIPTEN OR IOS) set(HELLOIMGUI_USE_SDL2 ON CACHE BOOL "" FORCE) set(HELLOIMGUI_HAS_OPENGL3 ON CACHE BOOL "" FORCE) else()