FIX multiInstance on remove

pubkey · Nov 27, 2024 · c74b089 · c74b089
1 parent 2517d92
commit c74b089
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/rx-collection-helper.ts b/src/rx-collection-helper.ts
@@ -82,6 +82,7 @@ export async function removeCollectionStorages(
     databaseInstanceToken: string,
     databaseName: string,
     collectionName: string,
+    multiInstance: boolean,
     password?: string,
     /**
      * If no hash function is provided,
@@ -134,11 +135,12 @@ export async function removeCollectionStorages(
                     databaseInstanceToken,
                     databaseName,
                     /**
-                     * multiInstance must be set to true,
+                     * multiInstance must be set to true if multiInstance
+                     * was true on the database
                      * so that the storageInstance can inform other
                      * instances about being removed.
                      */
-                    multiInstance: true,
+                    multiInstance,
                     options: {},
                     schema: row.schema,
                     password,

diff --git a/src/rx-collection.ts b/src/rx-collection.ts
@@ -936,6 +936,7 @@ export class RxCollectionBase<
             this.database.token,
             this.database.name,
             this.name,
+            this.database.multiInstance,
             this.database.password,
             this.database.hashFunction
         );

diff --git a/src/rx-database.ts b/src/rx-database.ts
@@ -677,6 +677,7 @@ export function createRxDatabase<
 export async function removeRxDatabase(
     databaseName: string,
     storage: RxStorage<any, any>,
+    multiInstance: boolean = true,
     password?: string
 ): Promise<string[]> {
     const databaseInstanceToken = randomToken(10);
@@ -700,6 +701,7 @@ export async function removeRxDatabase(
             databaseInstanceToken,
             databaseName,
             collectionName,
+            multiInstance,
             password
         ))
     );