Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputFile-Styling #6362

Closed
2 tasks done
laske185 opened this issue Apr 25, 2024 · 5 comments · Fixed by #7436
Closed
2 tasks done

InputFile-Styling #6362

laske185 opened this issue Apr 25, 2024 · 5 comments · Fixed by #7436
Assignees
Labels
feature New feature or request good first issue Good for newcomers v3 Here are issues that need to be resolved for version 3.

Comments

@laske185
Copy link
Contributor

laske185 commented Apr 25, 2024

Die Gestaltbarkeit des InputFile soll verbessert werden.

Todos:

  • Ausgewählte Datei anzeigen
  • Drag and Drop Support:
    • Anzeigen, wenn Datei über Input (drag-over)
    • Drop auf äußeres Label wählt Datei aus

So könnte es aussehen: https://bootstrap-vue.org/docs/components/form-file/

@laske185 laske185 converted this from a draft issue Apr 25, 2024
@laske185 laske185 added feature New feature or request good first issue Good for newcomers labels Apr 25, 2024
@laske185 laske185 moved this to 📄 Ready in KoliBri Board Apr 25, 2024
@laske185 laske185 moved this from 📄 Ready to Backlog in KoliBri Board May 2, 2024
@laske185 laske185 moved this from Backlog to 📄 Ready in KoliBri Board May 2, 2024
@chriskrj
Copy link

Ich habe unten einmal das Design Template für unsere Input File Komponente angefügt.

Sowohl Multi Upload als auch Single File Upload.

Dropzone habt ihr ja schon thematisiert. Was das ganze spannend macht, ist die Liste mit hochgeladenen Files und deren Upload Prozess. Hier sollte dann die kol-progress zum Einsatz kommen und die kol-badge für den Upload Status.

Ob das komplett auf Kolibriseite so implementiert werden muss, kann ich nicht beantworten, aber wenn nicht, gib uns gerne nochmal ein Hinweis, wie wir dann die kol-input-file um die nötigen Anpassungen erweitern könnten.

Neue Properties:

/**
* Defines the maximum file size in bytes.
*/
@Prop() public _maxFileSize?: maxFileSize;

/**
* Defines which file formats are accepted.
*/
@Prop() public _allowedFileTypes?: AllowedFileTypes[];

Komponenten Design:

Bildschirmfoto 2024-06-14 um 11 27 36

@laske185
Copy link
Contributor Author

laske185 commented Aug 26, 2024

Die Property für allowedFileTypes gibt es bereits. Es ist die _accept-Property (https://public-ui.github.io/docs/components/input-file#properties).

MaxFileSize sollte bei der Validierung innerhalb der Fachanwendung geprüft werden und nicht innerhalb der Komponente. Die Komponente kann das Folgeverhalten nicht entscheiden.

Copy link
Contributor

This issue has been automatically marked as stale and will be closed in 10 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, please post a comment or remove the Stale label.

@github-actions github-actions bot added the Stale label Feb 13, 2025
Copy link
Contributor

This issue was closed because it has been stale for 10 days with no activity. If the issue is still relevant to you, feel free to re-open with a comment.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2025
@github-project-automation github-project-automation bot moved this from 📄 Ready to ✅ Done in KoliBri Board Feb 24, 2025
@laske185 laske185 reopened this Feb 26, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in KoliBri Board Feb 26, 2025
@laske185 laske185 moved this from 🏗 In progress to 🗂️ Backlog in KoliBri Board Feb 26, 2025
@laske185 laske185 added v3 Here are issues that need to be resolved for version 3. and removed Stale labels Feb 26, 2025
@laske185 laske185 moved this from 🗂️ Backlog to 📄 Ready in KoliBri Board Feb 26, 2025
@anicyne anicyne self-assigned this Mar 3, 2025
@anicyne anicyne moved this from 📄 Ready to 🏗 In progress in KoliBri Board Mar 3, 2025
@anicyne anicyne linked a pull request Mar 3, 2025 that will close this issue
5 tasks
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 4, 2025
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Mar 4, 2025
@deleonio
Copy link
Contributor

deleonio commented Mar 4, 2025

Drag & drop? Ist das schon mit dabei?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers v3 Here are issues that need to be resolved for version 3.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants